You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
It must depend on docker to build binary, which seems to be bothering for users. Since it used to be able to build on MacOS, while with the target in Makefile, user cannot build dfget on MacOS nor Windows.
So I request to make dfget building without docker in Makefile. @fengzixu WDYT
In addition, in pr dragonflyoss/dragonfly#312, I have made it to gen-docs. But before generating, I must build a binary of dfget first. Then I need the feature.
How it could be?
make dfget building without docker in Makefile
Other related information
none
The text was updated successfully, but these errors were encountered:
When I refactored the dfget for the Dragonfly because the version of golang in my local environment is different with the circleCI used, I suffered many wired problems: Buiding dfget binary file is successful in the local, but it was processed fail during the CI. The root reason is that I used golang whose version is 1.11 and CI used golang whose version is 1.10.4.
That is an unnecessary problem for developers. Both I and @flyer103 also think that we should clear the inconsistencies between the local and CI. So, we refer to the repo: https://github.com/thockin/go-build-template. Actually, during my work, I used docker to build the binary files, so that I don't need to notice the version of dependencies between the production env and local env.
For your requirement, I think that there are two options
Install the docker in your machine, for holding the consistency between the CI and our local env.
Let me add the new command which can admit the user to build dfget and dfdaemon without the docker.
Why you need it?
dfget is very pure binary which is built from Golang 1.10.4, so we can easily build
dfget
binary from the source code. While I see in the Makefile, there are https://github.com/dragonflyoss/Dragonfly/blob/master/Makefile#L49-L65:It must depend on docker to build binary, which seems to be bothering for users. Since it used to be able to build on MacOS, while with the target in Makefile, user cannot build dfget on MacOS nor Windows.
So I request to make dfget building without docker in Makefile. @fengzixu WDYT
In addition, in pr dragonflyoss/dragonfly#312, I have made it to gen-docs. But before generating, I must build a binary of
dfget
first. Then I need the feature.How it could be?
make dfget building without docker in Makefile
Other related information
none
The text was updated successfully, but these errors were encountered: