Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unnecessary get_piece #869

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: remove unnecessary get_piece #869

merged 1 commit into from
Nov 26, 2024

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces several changes to the dragonfly-client-storage and dragonfly-client projects. The primary focus is on improving the codebase by making function parameters more consistent and adding new methods to check the existence of tasks, persistent cache tasks, and pieces. Additionally, error handling and logging are enhanced in some parts of the code.

Changes related to function parameters:

New methods for checking existence:

Error handling improvements:

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Nov 26, 2024
@gaius-qi gaius-qi added this to the v1.0.0 milestone Nov 26, 2024
@gaius-qi gaius-qi self-assigned this Nov 26, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner November 26, 2024 12:36
yxxhero
yxxhero previously approved these changes Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 34.30%. Comparing base (62c62f7) to head (ddc3d0b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/resource/task.rs 0.00% 6 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% 4 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 4 Missing ⚠️
dragonfly-client-storage/src/lib.rs 0.00% 3 Missing ⚠️
dragonfly-client-storage/src/metadata.rs 0.00% 3 Missing ⚠️
...onfly-client-storage/src/storage_engine/rocksdb.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
+ Coverage   33.19%   34.30%   +1.10%     
==========================================
  Files          57       57              
  Lines        8788     8883      +95     
==========================================
+ Hits         2917     3047     +130     
+ Misses       5871     5836      -35     
Files with missing lines Coverage Δ
dragonfly-client-storage/src/content.rs 3.30% <ø> (ø)
dragonfly-client-storage/src/storage_engine/mod.rs 100.00% <ø> (ø)
...onfly-client/src/resource/persistent_cache_task.rs 0.00% <ø> (ø)
dragonfly-client/src/resource/piece.rs 58.21% <ø> (+7.01%) ⬆️
...onfly-client-storage/src/storage_engine/rocksdb.rs 50.00% <0.00%> (-0.95%) ⬇️
dragonfly-client-storage/src/lib.rs 2.00% <0.00%> (-0.13%) ⬇️
dragonfly-client-storage/src/metadata.rs 58.63% <0.00%> (-0.72%) ⬇️
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% <0.00%> (ø)
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
dragonfly-client/src/resource/task.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 0d50958 into main Nov 26, 2024
6 checks passed
@gaius-qi gaius-qi deleted the feature/get branch November 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants