Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping the module for filling gaps #126

Open
4 of 10 tasks
Tracked by #121
GwennyGit opened this issue Jul 15, 2024 · 0 comments
Open
4 of 10 tasks
Tracked by #121

Revamping the module for filling gaps #126

GwennyGit opened this issue Jul 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested refactoring changes in the code functionality

Comments

@GwennyGit
Copy link
Collaborator

GwennyGit commented Jul 15, 2024

For the following reasons the module for gap-filling needs to be revamped:


Todo:

  • 🗄️ Reorganise gap filling as class set-up
    • Implement an abstract core class for gap analysis (GapFiller)
      • Determine which methods should be abstract & which should be already fully implemented $\rightarrow$ Fill classes with information from the OG modules
      • 📂 Output for gap analysis: Folder with several TSV/CSV files
    • Implement one class per analysis set-up: KEGGapFiller, BioCycGapFiller, GeneGapFiller
      • Fill classes with functionalities from the OG modules
    • 💡 Separate class for gap filling instead of function gapfill_model
      • 💡 Option to add either all new content from gap analysis to the model or restricted by namespace
      • ✍🏻 Report with statistics (+ some analyses?)
  • ❗Realise improvements during revamping
@GwennyGit GwennyGit added enhancement New feature or request help wanted Extra attention is needed question Further information is requested refactoring changes in the code functionality labels Jul 15, 2024
GwennyGit added a commit that referenced this issue Jul 18, 2024
cb-Hades added a commit that referenced this issue Jul 31, 2024
cb-Hades added a commit that referenced this issue Jul 31, 2024
cb-Hades added a commit that referenced this issue Aug 1, 2024
cb-Hades added a commit that referenced this issue Aug 7, 2024
cb-Hades added a commit that referenced this issue Aug 7, 2024
cb-Hades added a commit that referenced this issue Aug 8, 2024
first version of KEGG,MNX,BiGG reconstruction of metabolites and reactions
cb-Hades added a commit that referenced this issue Aug 9, 2024
Added functions for adding reac / metabs per database id
cb-Hades added a commit that referenced this issue Aug 12, 2024
some clean up, some new docstrings, started func for fill_model
cb-Hades added a commit that referenced this issue Aug 13, 2024
cb-Hades added a commit that referenced this issue Aug 13, 2024
Update funcs + tested GeneGapFiller and KEGGapFiller with fill_model
GwennyGit added a commit that referenced this issue Aug 14, 2024
GwennyGit added a commit that referenced this issue Aug 15, 2024
cb-Hades added a commit that referenced this issue Aug 19, 2024
changed missing genes and reacs to attributes instead of return values
GwennyGit added a commit that referenced this issue Aug 20, 2024
GwennyGit added a commit that referenced this issue Aug 21, 2024
- Adjusted due to new db_access set up
- Started writing code for mapping from BioCyc IDs to other databases for the BioCycGapFiller
GwennyGit added a commit that referenced this issue Aug 21, 2024
cb-Hades added a commit that referenced this issue Aug 21, 2024
GwennyGit added a commit that referenced this issue Aug 22, 2024
GwennyGit added a commit that referenced this issue Aug 22, 2024
GwennyGit added a commit that referenced this issue Aug 26, 2024
- Also added Finn Mier as author as Reihaneh's script is og from him
- Renamed all missing_reacs occurences to missing_reactions to fit subclasses to parent class
GwennyGit added a commit that referenced this issue Aug 28, 2024
GwennyGit added a commit that referenced this issue Aug 28, 2024
GwennyGit added a commit that referenced this issue Oct 28, 2024
GwennyGit added a commit that referenced this issue Oct 28, 2024
niinina added a commit that referenced this issue Nov 6, 2024
GwennyGit added a commit that referenced this issue Nov 15, 2024
Should labels be added automatically if None are in model for the GapFillers to work?
GwennyGit added a commit that referenced this issue Nov 20, 2024
niinina added a commit that referenced this issue Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested refactoring changes in the code functionality
Projects
None yet
Development

No branches or pull requests

2 participants