Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests should use actual metalsmith instance #8

Closed
leviwheatcroft opened this issue Feb 5, 2017 · 0 comments · Fixed by #18
Closed

tests should use actual metalsmith instance #8

leviwheatcroft opened this issue Feb 5, 2017 · 0 comments · Fixed by #18

Comments

@leviwheatcroft
Copy link

Currently the tests just use an analog, to feed the meta in and test against the resulting meta.

I ran into trouble with this in PR #7, tests were passing but plugin wouldn't work when called by metalsmith (I can't remember exactly what the bug was sorry)

Anyhow.. seems sensible to run the tests against an actual metalsmith instance.
webketje added a commit to webketje/metalsmith-filemetadata that referenced this issue May 31, 2020
@webketje
fix dpobel#8: use actual Metalsmith pipeline in tests
addcc92
@webketje webketje mentioned this issue May 31, 2020
Closed
webketje added a commit to webketje/metalsmith-filemetadata that referenced this issue Jun 13, 2020
@webketje
fix dpobel#8: use actual Metalsmith pipeline in tests
65557e8
@webketje webketje mentioned this issue Jun 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/use metalsmith in tests 1 webketje/metalsmith-filemetadata
1 participant
@leviwheatcroft