From 0e6b4d917ab456524a8bb770b6c4047785171882 Mon Sep 17 00:00:00 2001 From: Josua Schmid Date: Mon, 13 Sep 2021 16:53:57 +0200 Subject: [PATCH 1/2] Fix readme grammar --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 8a65c0c..c1424e0 100644 --- a/README.md +++ b/README.md @@ -151,12 +151,12 @@ docker_compose.yml files, IE: -d dperson/samba -p * Attempting to connect with the `smbclient` commandline tool. By default samba -still tries to use SMB1, which is depriciated and has security issues. This -container defaults to SMB2, which for no decernable reason even though it's -supported is disabled by default so run the command as `smbclient -m SMB3`, then +still tries to use SMB1, which is deprecated and has security issues. This +container defaults to SMB2, which for no discernible reason even though it's +support is disabled by default. So run the command as `smbclient -m SMB3`, then any other options you would specify. ## Issues If you have any problems with or questions about this image, please contact me -through a [GitHub issue](https://github.com/dperson/samba/issues). \ No newline at end of file +through a [GitHub issue](https://github.com/dperson/samba/issues). From fd3dfa15a89ef0f58124c50bd8a05e638d839161 Mon Sep 17 00:00:00 2001 From: Josua Schmid Date: Fri, 25 Nov 2022 16:04:54 +0100 Subject: [PATCH 2/2] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c1424e0..4797cc5 100644 --- a/README.md +++ b/README.md @@ -152,7 +152,7 @@ docker_compose.yml files, IE: * Attempting to connect with the `smbclient` commandline tool. By default samba still tries to use SMB1, which is deprecated and has security issues. This -container defaults to SMB2, which for no discernible reason even though it's +container defaults to SMB2, which for no discernible reason even though its support is disabled by default. So run the command as `smbclient -m SMB3`, then any other options you would specify.