Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption should be offered by default. #325

Open
jtagcat opened this issue Jul 19, 2020 · 4 comments · May be fixed by #326
Open

Encryption should be offered by default. #325

jtagcat opened this issue Jul 19, 2020 · 4 comments · May be fixed by #326

Comments

@jtagcat
Copy link

jtagcat commented Jul 19, 2020

GLOBAL1=smb encrypt = auto makes the server offer encryption

GLOBAL1=smb encrypt = mandatory makes the server enforce the encryption.

@jtagcat jtagcat linked a pull request Jul 19, 2020 that will close this issue
@mafredri
Copy link

I don't think anything needs to be done here. The default setting is default, and from the documentation, one of the possible values is:

A special value is default which is the implicit default setting of enabled.

(From https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html).

Enabled and auto are synonymous, AFAICT.

@jtagcat
Copy link
Author

jtagcat commented Jul 27, 2020

By default, I discovered that there was no encryption at all being used.

Maybe add some note about encryption then? Maybe give the GLOBAL1=smb encrypt = mandatory as an example on how quoting works (pretty much no quoting, though spaces and stuff are magically ok).

(I went 'I need a network share on a Windows machine in 1-2 hours. WebDav (already up and high availability online), almost, almost! Nope. Ok, samba. Ok, initial setup done, what do we have here. smbstatus, encryption none. ..over the normal internet. ..? What? I'd assume if a thing doesn't want to go through Traefik, it will offer it's own encryption. Now how will we encrypt this (20 minutes(!) later, trying to get it with the docker thing, discovering it appends, not replaces and how to get the setting in to the config (quoting caused some problems as well)))

@edocollado
Copy link

How to configure Docker for file encryption?

@jtagcat
Copy link
Author

jtagcat commented Oct 21, 2020

Add the env variables in the original comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants