-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win Celebration on Mobile #260
Comments
no objections from me! @cleercode any thoughts? |
+1 |
@lukevp @stevenhao Seems this issue can be closed now! |
This might be useful if someone is looking to improve the performance of "confetti" celebration across platforms: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use your site/app on mobile quite a bit, and it took us some time to realize that the only indication that we've solved the puzzle on mobile is the appearance of parenthesis and pausing of solve time, plus the highlight of green on the puzzle. On desktop, it's really obvious you've won because of the confetti burst introduced in #96 , which I only discovered many weeks later.
That PR specifically didn't show confetti on mobile because of "performance issues". Is that a real concern, or was that just an assumption? I can't imagine the performance is really a big deal for a couple of seconds, if anything. Granted, I have a nice phone (iPhone 13 Pro Max) but I tried several js confetti implementations and saw no slowness on any of them. Since the animation only plays for a few seconds, I don't see this being a major issue.
Would you be open to adding confetti support to mobile? It should be straightforward to remove the mobile check from the existing PR, and I'd be happy to do so if you're open to the change.
The text was updated successfully, but these errors were encountered: