From bea59daaa8c80d3ebe9524181181445ac5444847 Mon Sep 17 00:00:00 2001 From: Anthony Doud Date: Thu, 15 Aug 2024 11:27:50 -0500 Subject: [PATCH] updated "Contributing" directions --- CHANGELOG.md | 1 + README.md | 8 +++++--- src/Main.cpp | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a1cdb3ad..c5be7a66 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Removed extra logging when loading table. - Prevent table returns from going in the wrong direction. - Fixed bug with stepper speed not updating. +- Removed driver temp checking. It's not accurate on the ESP32. ### Hardware diff --git a/README.md b/README.md index eb5d8e88..79dead68 100644 --- a/README.md +++ b/README.md @@ -59,9 +59,11 @@ Everything you need to know is in the [SS2K Wiki](https://github.com/doudar/Smar ## Contributing 1. Install Microsoft Visual Code. https://code.visualstudio.com/ 2. Install PlatformIO into Visual Code. https://platformio.org/platformio-ide -3. Install Pre-commit. https://pre-commit.com -4. Install pre-push git hooks: `pre-commit install --hook-type pre-push` -5. Open this project in PlatformIO. +3. Install Python https://www.python.org/downloads/ +4. Install Pre-commit. https://pre-commit.com `py -m pip install pre-commit` +5. Follow any install warnings to add pre-commit to your path. +6. Install pre-push git hooks: `pre-commit install --hook-type pre-push` +7. Open this project in PlatformIO. ## Important announcement for existing users If you experience an issue after upgrading firmware, please follow these instructions in the Wiki. Flashing instructions are available [HERE.](https://github.com/doudar/SmartSpin2k/wiki/Loading-Software) diff --git a/src/Main.cpp b/src/Main.cpp index f662a821..124740d2 100644 --- a/src/Main.cpp +++ b/src/Main.cpp @@ -275,7 +275,9 @@ void SS2K::maintenanceLoop(void *pvParameters) { // Things to do every 20 loops if (loopCounter > 20) { - ss2k->checkDriverTemperature(); + // Removed driver temp checking. This really doesn't do anything benificial anyway, because the thermistors in the ESP32 are not accurate. + // The Driver itsself will throttle automatically if the temp is too high. + // ss2k->checkDriverTemperature(); #ifdef DEBUG_STACK Serial.printf("Step Task: %d \n", uxTaskGetStackHighWaterMark(moveStepperTask));