-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for react-native-web? #572
Comments
I have worked on a port for react-native-web a long time ago, but I've never published. I might update it and push it. |
@Guichaguri That's great! Waiting for this 😄 |
Hey, @Guichaguri Did you get a chance to publish the react-native-web port? |
Before publishing, I think we should discuss about implementation details:
Let me know what do you think |
Most cross platform libraries, that support react-native-web have a necessity to add a separate module with the same API, so I believe that's what suits us as well. It seems to me that HTML5 Audio is the way to go for web, because of obvious reasons. Although it doesn't support adaptive streaming immediately, I see it as a feature that's implemented after we have identified that rn-track-player works well enough on HTML5 Audio in Web. I have limited understanding of the MediaSession API, but it looks like an interface for browser to know about the audio track currently playing, along with some extra information. Afaik, this also doesn't feel like a huge priority for RN-Web initially. Also with such limited browser support now, I personally feel like its best to defer this feature until there's better support or if there's an alternative way to do the same. Cast and Airplay do seem like important features, although not the top most in the priority list imho. If there are any unfinished parts that require contributions from the community, please do let me know and I will try to see if I can also contribute in some way, especially in adding support for web. I'm building an open-source, cross-platform podcast app for developers, and I'm keen on using react-native-track-player for all the platforms 😄 |
Hey, my team is heavily using this library and we're going to be adding support for RN Web to our project soon. Has this gone anywhere? Do y'all need some help? |
Can we publish as a beta or another package for now? Then the community can aid in testing and development. |
@Guichaguri it would be nice if you can push your work so we can contribute and move forward :) |
Hola @Guichaguri sorry to be insistent on this, i've start to work on a web version of the project, but it would be nice if you can share what you've done before and the discus what the next steps are as you asked :) please let us know if you have some time for this, thank you :) |
@Guichaguri A little update to this post! Also interested to see a possibility of integration with RN-web, especially that the V2 of react-native-track-player is on! |
Any news on this? |
@andordavoti , I've created a PR for this here #1886 that you can take a look at. That fork is also published here https://www.npmjs.com/package/@5stones/react-native-track-player/v/4.0.0-web.9 The core team has had a bit of discussion about merging it into the repo at some point, however we haven't had the time to seriously discuss it yet. Generally, there is interest in doing so I think and I think it probably will happen someday. Please test it out and give feedback! |
@jspizziri Thanks for the quick reply! Will definitely take a look at it, would be awesome for simplifying migration of my native app to web:) |
Hey,
Found this library to be really helpful, are there any plans of porting this to react-native-web now?
The text was updated successfully, but these errors were encountered: