Introduce Rust based Vocabulary type #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
main
branch
from
e63edab to
c39600f
Compare
brandonwillard
force-pushed
the
vocabulary
branch
from
96af432 to
26cf28e
Compare
This was required because vocabulary was no longer ordered. So returning a vector was causing ordering issues.
umut-sahin
force-pushed
the
vocabulary
branch
from
23735fb to
8bd018c
Compare
brandonwillard
approved these changes
Sep 24, 2024
brandonwillard
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #26)
This type is not exposed in Python, which will be done in a subsequent PR, once this one is merged. Underlying type changed from a
Vecto aHashMapto have efficient insertion (i.e., to avoid searching the token in the vec). SinceHashMap<Key, Value>has the same iteration semantics asVec<(Key, Value)>no changes were needed where the vocabulary is used.