-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and build process #20
Conversation
Btw if everything's cool could you @brandonwillard merge it? I don't seem to have the permissions. |
efbadce
to
2e8498d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I set up the tokens and tried the crates.io publish step locally, so it should work; however, I noticed that we might want to change the crate name to simply outlines-core
and we might also need to explicitly list the license type.
Thank you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to do anything for publish to docs.rs
.
docs.rs automatically publishes all crates uploaded to crates.io (see https://docs.rs/releases/queue).
c0de9e5
to
ea25968
Compare
Regarding the failing test: this seems to fail on main as well. Not sure if something was updated in the Regardless, maybe we shouldn't block this PR on that test failing, but rather have a separate issue for it? |
Yeah, it looks like we have some rebasing to do. |
Indeed! Thank you for merging 👍 |
Resolves: #18 and #21
Tasks for the python package:
Tasks for the rust crate:
*we probably want to start by duplicating the tests from python to rust --> run them in parallel for a while --> once we're confident enough we can then start deleting some of the duplicate tests.
Supported python versions and architectures in the PR:
notably musllinux
is not on the list, maybe we want to support it?Edit: yes, the alpine linux (docker image) uses musl libc, so it makes sense supporting it.
**Edit: I'll defer any more in depth rust code documentation. The code itself is quite self documenting when published to crates & docs. More detailed stuff is probably better done once we have a more clear understanding what the API will look like in the long run.
Additional question: A lot of the CI workflow are such that they cannot be tested without actually making a release. So it's quite likely that they have some bugs. I'd recommend that we do a pre-release. Something like version
0.1.0-dev0
to make sure everything runs smoothly. The requirement would thus be that we are comfortable in making this work somewhat public. Would that be okay for you?