Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test_guide tests to test_regex #71

Open
brandonwillard opened this issue Oct 10, 2024 · 0 comments · May be fixed by #125
Open

Move test_guide tests to test_regex #71

brandonwillard opened this issue Oct 10, 2024 · 0 comments · May be fixed by #125
Assignees
@torymur
Labels
enhancement New feature or request

Comments

@brandonwillard
Copy link
Member

Tests like test_regex_multi_byte_llama_like and test_regex_multi_byte_gpt2_like in test_guide are really tests for the vocabulary and FSM construction/conversion logic, which exists in regex.py, so we should break those down and move them to test_regex.
@brandonwillard brandonwillard added enhancement New feature or request help wanted Extra attention is needed labels Oct 10, 2024
@brandonwillard brandonwillard mentioned this issue Oct 10, 2024
Closed
@torymur torymur linked a pull request Dec 20, 2024 that will close this issue
Draft
12 tasks
@torymur torymur removed the help wanted Extra attention is needed label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torymur torymur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build Index from regex dottxt-ai/outlines-core
2 participants
@brandonwillard @torymur