-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Index
from regex
#125
Open
torymur
wants to merge
30
commits into
main
Choose a base branch
from
index-from-regex-97
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,211
−2,563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supersedes #38? |
Yes, it will |
torymur
force-pushed
the
index-from-regex-97
branch
2 times, most recently
from
December 18, 2024 15:50
fa36be9
to
5b8808d
Compare
torymur
force-pushed
the
index-from-regex-97
branch
3 times, most recently
from
January 7, 2025 17:54
88d609b
to
52edc6d
Compare
torymur
force-pushed
the
index-from-regex-97
branch
from
January 9, 2025 18:12
1a8831a
to
bf6e8a6
Compare
torymur
commented
Jan 9, 2025
torymur
force-pushed
the
index-from-regex-97
branch
from
January 10, 2025 13:09
5ea7e10
to
3fef1d8
Compare
torymur
commented
Jan 13, 2025
umut-sahin
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall 💯
torymur
commented
Jan 14, 2025
torymur
commented
Jan 15, 2025
dpsimpson
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statistical test is fixed.
torymur
force-pushed
the
index-from-regex-97
branch
from
January 16, 2025 10:55
b8d91ea
to
6bedffa
Compare
umut-sahin
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops all intermediate python and related rust structures and builds an
Index
from regex purely in rust. Also stabilizing python bindings forVocabulary
,Index
andGuide
and rust interfaces forVocabulary
andIndex
.index
from regex #97interegular
functionality #38 and closes Port necessaryinteregular
functionality #8walk_fsm
tests to Rust #68create_fsm_index_end_to_end
tests to Rust #69test_guide
tests totest_regex
#71Rust
Index
from regex withregex-automata
Token
type fromString
toVec<u8>
Vocabulary
'seos_token_id
fromOption<TokenId>
toTokenId
Index
interfaceIndex
python binding interfaceVocabulary
interfaceVocabulary
python binding interfaceinterregular
workflowGuide
python bindingPython
interregular
workflowGuide
,Index
&Vocabulary
Benchmarks
Benchmarks reveal x10+ times on average improvement for index compilation comparing to the current main branch.
On my machine to the degree, where a showcase with setting longer GIL switch interval for multithreaded case doesn't exhibit difference with one thread (because it's so fast in the first place, that there is a little sense to give it more time to execute without interruption), but it depends on machine.