Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate serialization solution after python bindings stabilization #101

Open
torymur opened this issue Dec 2, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@torymur
Copy link
Contributor

torymur commented Dec 2, 2024

We need to investigate serialization options after python bindings will stabilize (and loose many intermediary structures we have to support right now).

One solution was introduced with bincode and Python::with_gil, which is currently considered to be a temp measure to prevent vLLM integration failures: #99

There are some other potential issues with bincode, which needs to be confirmed. For example, it's not self-descriptive, so if Index changes in any way (e.g., field order, type, or size), deserialization will fail. Also bincode serialization may produce architecture-dependent binaries, differences in endianness or data alignment between 32-bit and 64-bit systems could lead to deserialization errors. bincode has support for serde integration, which could be enabled with the serde feature (we'd need to check for the exact impl details too).

@torymur torymur added the enhancement New feature or request label Dec 2, 2024
@torymur torymur self-assigned this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant