You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to investigate serialization options after python bindings will stabilize (and loose many intermediary structures we have to support right now).
One solution was introduced with bincode and Python::with_gil, which is currently considered to be a temp measure to prevent vLLM integration failures: #99
There are some other potential issues with bincode, which needs to be confirmed. For example, it's not self-descriptive, so if Index changes in any way (e.g., field order, type, or size), deserialization will fail. Also bincode serialization may produce architecture-dependent binaries, differences in endianness or data alignment between 32-bit and 64-bit systems could lead to deserialization errors. bincode has support for serde integration, which could be enabled with the serde feature (we'd need to check for the exact impl details too).
The text was updated successfully, but these errors were encountered:
We need to investigate serialization options after python bindings will stabilize (and loose many intermediary structures we have to support right now).
One solution was introduced with
bincode
andPython::with_gil
, which is currently considered to be a temp measure to prevent vLLM integration failures: #99There are some other potential issues with
bincode
, which needs to be confirmed. For example, it's not self-descriptive, so ifIndex
changes in any way (e.g., field order, type, or size), deserialization will fail. Alsobincode
serialization may produce architecture-dependent binaries, differences in endianness or data alignment between 32-bit and 64-bit systems could lead to deserialization errors.bincode
has support forserde
integration, which could be enabled with the serde feature (we'd need to check for the exact impl details too).The text was updated successfully, but these errors were encountered: