Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Classification Should Come from Repo that Produces DLL #4796

Open
lonitra opened this issue Nov 27, 2024 · 0 comments
Open

Profile Classification Should Come from Repo that Produces DLL #4796

lonitra opened this issue Nov 27, 2024 · 0 comments

Comments

@lonitra
Copy link
Member

lonitra commented Nov 27, 2024

In windowsdesktop we have profiling for dlls in the ref and runtime pack
Currently the profile specification for dlls in the ref/runtime pack is disconnected from the repos that actually produce them, which can easily lead to mis profiling the dlls.
In WinForms, we have https://github.com/dotnet/winforms/blob/main/pkg/Microsoft.Private.Winforms/sdk/dotnet-windowsdesktop/System.Windows.Forms.FileClassification.props which profiles all winforms dlls for the ref pack and windowsdesktop simply pulls this in via https://github.com/dotnet/windowsdesktop/blob/main/src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Ref.sfxproj#L25. We should set up a similar system for WPF and for the runtime pack to help with the disconnect and avoid mis profiling dlls.

Note that when it comes to the runtime pack, analyzers should not be included #4227 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant