Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve baseline determination when comparing VMR and MSFT builds #4763

Open
4 tasks
mmitche opened this issue Nov 26, 2024 · 1 comment
Open
4 tasks

Improve baseline determination when comparing VMR and MSFT builds #4763

mmitche opened this issue Nov 26, 2024 · 1 comment
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Nov 26, 2024

Today, when we do asset comparison between VMR and MSFT builds, we find artifacts with the same version as the VMR produced artifact and compare the contents. Unfortunately, this will cause us to miss comparisons. Artifacts not produced by the VMR will not be validated. This issue covers revamping this process to determine a proper baseline.

I think this could be done in a few ways:

  • Manually prepared baselines that are updated on a cadence.
  • Use gather drop, plus some heuristics to download a baseline.

Any way this is done, the goals are:

  • We should be able to tell what artifacts are missing from the VMR build.
  • The baseline should be relatively simple to update
  • The baseline should be coherent.
  • The baseline should not rely on 1:1 version matches
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Nov 26, 2024
@MichaelSimons MichaelSimons added area-unified-build and removed untriaged area-build Improvements in source-build's own build process labels Dec 2, 2024
@mmitche
Copy link
Member Author

mmitche commented Jan 6, 2025

@wtgodbe This is the other issue for you to focus on outside of the hosting bundle. Figuring out how we do our assets comparisons in a robust manner.

@MichaelSimons MichaelSimons moved this to In Progress in .NET Unified Build Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants