Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - ((Type|null):Interface) subsumption in function return values can bypass nullness #18232

Open
1 of 7 tasks
T-Gro opened this issue Jan 13, 2025 · 0 comments · May be fixed by #18261
Open
1 of 7 tasks
Assignees
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Milestone

Comments

@T-Gro
Copy link
Member

T-Gro commented Jan 13, 2025

Issue description

When a function is explicitely annotated to return an instance of an interface, a nullable class implementing can be returned without warnings.
The same error does not occur when subsuming a type with its super type.
The same error does not occur when subsuming an interface with nullable version of the same.

The bug (= i.e. not getting any warning) also occurs when subsuming a nullable version of an interface into a non-nullable parent interface.

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

NET9

Reproducible code snippet and actual behavior

    open System.IO
    open System
    open System.Collections

    let whatisThis (s:Stream|null) : IDisposable =
        s

    let whatisThis2 (s:ICollection|null) : IEnumerable =
        s

Possible workarounds

No response

@T-Gro T-Gro added Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage labels Jan 13, 2025
@T-Gro T-Gro self-assigned this Jan 13, 2025
@github-actions github-actions bot added this to the Backlog milestone Jan 13, 2025
@T-Gro T-Gro added Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. and removed Needs-Triage labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code.
Projects
Status: New
Development

Successfully merging a pull request may close this issue.

1 participant