Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETSDKE2E][Loc]With NET9 RC2 SDK installed, some strings are unlocalized in output of "dotnet workload search --help". #2499

Open
vdanche opened this issue Sep 18, 2024 · 9 comments

Comments

@vdanche
Copy link
Member

vdanche commented Sep 18, 2024

Repro
1.install NET9 RC2 SDK on Loc windows OS. e.g Chinese/German
2. Run dotnet workload search --help
3. Run dotnet workload search version

Expected Result:
In Step2 & Step3, the output are displayed well

Actual Result:
Some strings are unlocalized

Chinese:
image

German:
image

EN:
image

dotnet --info:
.NET SDK:
Version: 9.0.100-rc.2.24467.36
Commit: 4d4e5761c3
Workload version: 9.0.100-manifests.47de87af
MSBuild version: 17.12.0-preview-24466-06+be6149fc8

运行时环境:
OS Name: Windows
OS Version: 10.0.22621
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\9.0.100-rc.2.24467.36\

已安装 .NET 工作负载:
没有要显示的已安装工作负载。
配置为在安装新清单时使用 workload sets。
Workloads are configured to install and update using workload versions, but none were found. Run "dotnet workload restore" to install a workload version.

Host:
Version: 9.0.0-rc.2.24463.7
Architecture: x64
Commit: static

.NET SDKs installed:
9.0.100-rc.2.24467.36 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 9.0.0-rtm.24466.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 9.0.0-rc.2.24463.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 9.0.0-rtm.24467.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
None

Environment variables:
Not set

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

@baronfel
Copy link
Member

This is probably just because that was recently implemented and we don't have localizations for those yet.

@vdanche vdanche changed the title [NETSDKE2E]With NET9 RC2 SDK installed, some strings are unlocalized in output of "dotnet workload search --help". [NETSDKE2E][Loc]With NET9 RC2 SDK installed, some strings are unlocalized in output of "dotnet workload search --help". Sep 18, 2024
@NicoleWang001
Copy link
Member

This issue is still repro with 9.0.100-rc.2.24474.11
image

@vdtirlochan
Copy link

The issue is still reproducible on 9.0.100-rtm.24503.11
image

@vdanche
Copy link
Member Author

vdanche commented Oct 11, 2024

Some strings are fixed on 9.0.100-rtm.24509.28 (runtime-9.0.0-rtm.24503.8), But string "description" is unlocalized.
German
Image
Chinese
Image

@baronfel

@richaverma1
Copy link

@marcpopMSFT the bug is not completely fixed, can you take a look?

@marcpopMSFT
Copy link
Member

@baronfel that Description: label is in the help and I was pretty sure we saw this before and it comes from system.commandline. I thought this was fixed for the other commands? Is it not fixed or is there something we need to do to get that to come localized from S.CL?

@baronfel
Copy link
Member

@marcpopMSFT yeah, that string is unlocalized in the S.CL sources - @KathleenDollard / @jonsequitur do you know if loc is happening for S.CL?

@marcpopMSFT
Copy link
Member

maybe we just moved the last bug over. I'll move this one.

@marcpopMSFT marcpopMSFT transferred this issue from dotnet/sdk Oct 16, 2024
@vdanche
Copy link
Member Author

vdanche commented Oct 24, 2024

still happens 9.0.100 sdk
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants