-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve start/stopping/restarting commands by waiting for completion #6625
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/Aspire.Hosting/ApplicationModel/CommandsConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/CommandsConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
@@ -8,6 +8,8 @@ namespace Aspire.Hosting.ApplicationModel; | |||
|
|||
internal static class CommandsConfigurationExtensions | |||
{ | |||
private static readonly TimeSpan s_timeout = TimeSpan.FromSeconds(20); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you pick this number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked it myself. It seems like 20 seconds is a good amount of time for a timeout.
Edit: I added a comment to say how number was chosen.
8d9327a
to
8294ab1
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Fixes #6224
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):Microsoft Reviewers: Open in CodeFlow