Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ feature/drop_details ] Drop Details #11

Open
8 of 21 tasks
DominicF96 opened this issue Dec 15, 2021 · 0 comments
Open
8 of 21 tasks

[ feature/drop_details ] Drop Details #11

DominicF96 opened this issue Dec 15, 2021 · 0 comments
Labels
Documentation Changes only affect the documentation Feature Feature to be implemented Good First Issue Good for newcomers Testing Related to Automated Testing
Milestone

Comments

@DominicF96
Copy link
Contributor

DominicF96 commented Dec 15, 2021

Displays a drop's core information.

Definition of Done

This section describes what needs to be done to consider this component's implementation complete.

Component's Feature

Here, list all the feature your component should support.

  • The artist can be shown / hidden
  • The collection can be shown / hidden
  • The current mint and total mint is displayed
  • The about can be shown / hidden
  • Can display / hide transferable and burnable

Standard Verifications

To maintain a quality standard, every component should pass through standard verifications. For example, most components implement standard props. That means that they have to support a few features by default. We also make sure that your component's props respects our standards.

  • The component is responsive
  • All the dynamic data displayed by the component is grouped under the data prop
  • All behaviour related data (to control the state of the component and receive feedback) is grouped under the config prop
  • If the component a default configuration, it is assigned directly in the destructuring of the props

Standard Props

  • The component support different sizes (size prop)
  • The component support different variants (variant prop)
  • The component's main parts support custom styling through className objects
  • Hardcoded labels are localized and overrideable

Documentation

In a UI library, a component really isn't really ready until well documented, therefore, we make some verifications here.

  • The component is documented in Storybook's doc
  • The props of the component are documented in Storybook's doc
  • There are at least 2 examples of common component usage

Testing

List the tests to be written for every feature of your component to ensure the robustness and predictability of your component.

  • The artist can be shown / hidden
  • The collection can be shown / hidden
  • The current mint and total mint is displayed
  • The about can be shown / hidden
  • Can display / hide transferable and burnable
@DominicF96 DominicF96 added the Good First Issue Good for newcomers label Dec 15, 2021
@DominicF96 DominicF96 added this to the 1.0.0-alpha milestone Dec 15, 2021
@DominicF96 DominicF96 added Documentation Changes only affect the documentation Feature Feature to be implemented Testing Related to Automated Testing labels Dec 15, 2021
@DominicF96 DominicF96 moved this to In Progress in dotGems UI Library (React) Feb 4, 2022
@DominicF96 DominicF96 moved this from In Progress to On Hold in dotGems UI Library (React) Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Changes only affect the documentation Feature Feature to be implemented Good First Issue Good for newcomers Testing Related to Automated Testing
Projects
Development

No branches or pull requests

1 participant