Disable following links #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following links resulted on my machine (running NixOS and using devenv) in precompilation attempting to format read-only .jl files (because `.devenv/profile` links to readonly `/nix/store/…` directories). Since I don't see a case where you may want JuliaFormatter to jump to far-away directory by following links (looks rather dangerous to me, actually?), I simply disabled following links. Note this could be improved by checking whether the link points to a file within the currently-to-be-formatted directory.
|
makes sense thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for developing and maintaining this project! 🙂
Following links resulted on my machine (running NixOS and using devenv) in precompilation of JuliaFormatter failing because it attempted to format read-only
.jlfiles (because.devenv/profilelinks to readonly/nix/store/…directories). Since I don't see a case where I want JuliaFormatter to jump to far-away directories by following links and reformat them (looks rather dangerous to me, actually?), I simply disabled following links. In case you want to integrate this tiny change, I created this PR.Note that this could be improved by checking whether the link points to a file within the currently-to-be-formatted directory or something like that.