fix for #753 #754
Merged
fix for #753 #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domluna
commented
Sep 9, 2023
src/styles/sciml/nest.jl
Outdated
| @@ -38,7 +38,14 @@ function n_binaryopcall!(ss::SciMLStyle, fst::FST, s::State; indent::Int = -1) | |||
| line_margin = s.line_offset + length(fst) + fst.extra_margin | |||
| if line_margin > s.opts.margin && | |||
| fst.ref !== nothing && | |||
| CSTParser.defines_function(fst.ref[]) | |||
| ( | |||
There was a problem hiding this comment.
@ChrisRackauckas should another check for short_to_long_function_def be added here or is it intentional to not check?
There was a problem hiding this comment.
the check is now in the pass itself so all that's left is verify that we can to make try transform always, even if short_to_long_function_def is set to false
There was a problem hiding this comment.
should another check for short_to_long_function_def be added here or is it intentional to not check?
That I don't know, @YingboMa wrote that I think?
|
@JuliaRegistrator register |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.