Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Element.ReplaceChildren #85

Open
alexflint opened this issue Aug 6, 2023 · 1 comment
Open

Add Element.ReplaceChildren #85

alexflint opened this issue Aug 6, 2023 · 1 comment

Comments

@alexflint
Copy link

Would it be possible to implement Element.ReplaceChildren?

I'd be happy to submit a PR.
@alexflint alexflint changed the title Element.ReplaceChildren Add Element.ReplaceChildren Aug 6, 2023
@dmitshur
Copy link
Collaborator

dmitshur commented Aug 8, 2023

Have you thought about what signature it would use in Go?

It seems the JavaScript version of this API permits the parameters to be either Nodes or strings, which unfortunately complicates things. I think it means we either don't support one of them, or need to use interface{} as the type, or end up having two versions of the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexflint @dmitshur