Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quais] - Integrate with Core endpoint for estimated gas and estimated base fee #21

Closed
mibuono opened this issue Feb 7, 2024 · 2 comments · Fixed by #49
Closed

[Quais] - Integrate with Core endpoint for estimated gas and estimated base fee #21

mibuono opened this issue Feb 7, 2024 · 2 comments · Fixed by #49

Comments

@mibuono
Copy link

mibuono commented Feb 7, 2024

Integrate with the Core endpoint for reading the estimated gas and estimated base fee.

Need the get the base fee in the unit that you're interested in. Base fee should be overloaded to return one or the other.

@rileystephens28 rileystephens28 changed the title [Quais] - Integrate with Qi Core Qi endpoint for estimated gas and estimated base fee [Quais] - Integrate with Core endpoint for estimated gas and estimated base fee Mar 6, 2024
@rileystephens28
Copy link
Member

Estimate Gas
The current version of go-quai-libp2p overloads the quai_estimateGas rpc method, therefore there is no additional work to do for quais.

Base Fee
The current version of go-quai-libp2p overloads the quai_baseFee rpc method, however, the Qi implementation is incomplete.
In quais, the base fee is currently calculated based on the base fee from the previous block, this needs to change to call the available quai_baseFee rpc method. This will require adding getBaseFee to the methods switch case in

Must modify the AbstractProvider.getFeeData method to accept a txType (0/1 or boolean type can be used) input param that will be passed along to the quai_baseFee rpc call. The txType param will determine whether the base fee is returned in units of quai (Wei or whatever the quai equivalent is) or qi (Qit)

@robertlincecum robertlincecum linked a pull request Mar 14, 2024 that will close this issue
@rileystephens28
Copy link
Member

This will be in review until we get the QIP 2 implementation merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants