New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quais] Improvements to quais HD wallets #179

Closed

alejoacosta74 opened this issue Jun 10, 2024 · 0 comments · Fixed by #180

Assignees

Labels

Quais

Contributor

alejoacosta74 commented Jun 10, 2024

Improvements to Qi and Quai HD wallets:

Rename class to AbstractHDWallet
Semantic change in order of inputs to the addAddress method (account, addressIndex, zone)
Update validateZone method to use Enum zone byte
Replace "naked" address term with "gap"
Add the public modifier to all public methods
Remove the _parentPath variable in favor of calculating it in the parentPath

alejoacosta74 self-assigned this

alejoacosta74 added the Quais label

alejoacosta74 linked a pull request

that will close this issue

Wallet improvements #180

Merged

rileystephens28 closed this as completed in #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment