Fee filtering, plus tests #2400
Open
+212
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djadih
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
Djadih
force-pushed
the
fee-filter
branch
5 times, most recently
from
001d051 to
d46c998
Compare
wizeguyy
previously approved these changes
Dec 17, 2024
Djadih
force-pushed
the
fee-filter
branch
2 times, most recently
from
f5b60fd to
2e4a598
Compare
wizeguyy
previously approved these changes
Dec 17, 2024
Djadih
force-pushed
the
fee-filter
branch
2 times, most recently
from
456e863 to
58dc991
Compare
| @@ -1457,7 +1455,7 @@ func ProcessQiTx(tx *types.Transaction, chain ChainContext, checkSig bool, isFir | |||
| elapsedTime = time.Since(stepStart) | |||
| stepTimings["Signature Check"] = elapsedTime | |||
|
|
|||
| return qiTxFee, txFeeInQit, etxs, nil, stepTimings | |||
| return txFeeInQit, txFeeInQit, etxs, nil, stepTimings | |||
There was a problem hiding this comment.
since this is going into main, we should remove this duplicate return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.