Graphql, Web: pull from and push to remotes #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbantle22
reviewed
Dec 6, 2024
web/renderer/components/pageComponents/DatabasePage/ForRemotes/RemotesPage/RemoteRow.tsx
Outdated
Show resolved
Hide resolved
web/renderer/components/pageComponents/DatabasePage/ForRemotes/RemotesPage/PullFromModal.tsx
Outdated
Show resolved
Hide resolved
...renderer/components/pageComponents/DatabasePage/ForRemotes/RemotesPage/PushToRemoteModal.tsx
Outdated
Show resolved
Hide resolved
...renderer/components/pageComponents/DatabasePage/ForRemotes/RemotesPage/PushToRemoteModal.tsx
Outdated
Show resolved
Hide resolved
...renderer/components/pageComponents/DatabasePage/ForRemotes/RemotesPage/PushToRemoteModal.tsx
Outdated
Show resolved
Hide resolved
web/renderer/components/pageComponents/DatabasePage/ForRemotes/RemotesPage/PullFromModal.tsx
Outdated
Show resolved
Hide resolved
...renderer/components/pageComponents/DatabasePage/ForRemotes/RemotesPage/PushToRemoteModal.tsx
Outdated
Show resolved
Hide resolved
tbantle22
approved these changes
Dec 6, 2024
graphql-server/schema.gql
Outdated
| @@ -291,6 +291,17 @@ type RemoteList { | |||
| list: [Remote!]! | |||
| } | |||
|
|
|||
| type PullRes { | |||
| fastForward: Boolean! | |||
| conflicts: Float! | |||
There was a problem hiding this comment.
You need _type => Int in this Field in the model
|
|
||
| export function fromPullRes(r: RawRow): PullRes { | ||
| return { | ||
| fastForward: r.fast_forward !== "0", |
There was a problem hiding this comment.
I think this should both be r.fast_forward === "1". In case some weird int gets in there you want it to be false in all circumstances except for 1
|
|
||
| export function fromPushRes(r: RawRow): PushRes { | ||
| return { | ||
| status: r.status === "0", |
There was a problem hiding this comment.
Since status is kinda unclear you could make this field success if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions dropdown:
push
pull
