-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use a PEP-440 compatible version number #6
Comments
IMO, commits just to set the version string are useless noise. The version string itself is pretty useless at the moment anyway, because both the code and the API are very much unstable. Once we've decided on a stable API and are ready to make stable releases, then we'll set the version string appropriately. |
On Sun, 21 Dec 2014 23:03:13 -0800
Since this is still in development for use in several Gentoo utilities,
For live builds of git code, I'll look at adding some code to identify There are several primary apps that use this lib that are the main
I agree, but see the previous comments. If you don't mind my asking, What distro/os are you using this lib? So far I know of one gentoo specific tool (using ssl-fetch) is being If you have some feature requests or patches, then please submit them.
Brian Dolbec |
Just wanted to let you know that this issue is causing nasty breakages on my Sabayon system (Sabayon is a Gentoo-based distro) whenever I upgrade packages. During clean-up following package installation I often get messages like
The annoying thing here is that this just seems to be a warning but it's causing the entire upgrade process to bail out because it thinks an error has occurred... |
The actual error is here:
You should file a bug with Sabayon. |
I did :-) |
The Python packaging world is moving towards normalized version numbers described in PEP 386 (the currently accepted standard) and PEP 440 (new draft intended to replace PEP 386).
Please use a version number like 0.2.1 instead of just "Git" for the next release, to be compatible with the PEPs.
(Personally, I prefer changing the version number in https://github.com/dol-sen/ssl-fetch/blob/master/sslfetch/__init__.py to '0.2.1dev0' right after I release 0.2.1, and then change it to '0.2.2' just before I release it, so that a random checkout could not be confused with a released version).
In short, the version in https://github.com/dol-sen/ssl-fetch/blob/master/sslfetch/__init__.py should be the same as the version used when creating the git tag and the same as is used when referring to the released archive, and not just the constant string "Git".
The text was updated successfully, but these errors were encountered: