Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images on "The Doki Theme Update" tab do not appear to be scaled correctly #468

Closed
justalemon opened this issue Dec 9, 2021 · 10 comments · Fixed by #469
Closed

Images on "The Doki Theme Update" tab do not appear to be scaled correctly #468

justalemon opened this issue Dec 9, 2021 · 10 comments · Fixed by #469

Comments

@justalemon
Copy link

Describe the bug

It appears that the images shown on the Update tab of the theme (automatically opened when you install or update the theme) do not correctly scale to the width of the tab

To Reproduce

  1. Open the Update tab on a resolution lower than 1080p.

Expected Behavior

The image is scaled to the width of the tab, so you don't have to use the scroll bar at the bottom to see the image.

Environment

JetBrains Rider 2021.2.2
Build #RD-212.5284.64, built on October 8, 2021
Licensed to Rider Evaluator
Expiration date: January 7, 2022
Runtime version: 11.0.12+7-b1504.28 amd64
VM: Dynamic Code Evolution 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
.NET Framework 4.0.30319.42000
GC: G1 Young Generation, G1 Old Generation
Memory: 1500M
Cores: 4
Registry: debugger.new.debug.tool.window.view=TRUE, ide.tree.horizontal.default.autoscrolling=FALSE, ide.tooltip.showAllSeverities=TRUE, ide.mac.bigsur.alerts.enabled=TRUE, show.diff.preview.as.editor.tab.with.single.click=TRUE, ea.enable.developers.list=FALSE, parameter.info.max.visible.rows=10, ide.win.file.chooser.native=TRUE, ide.mac.file.chooser.native=TRUE, search.everywhere.pattern.checking=FALSE, performance.watcher.sampling.interval.ms=200, ide.borderless.tab.caption.in.title=FALSE, awt.file.dialog.enable.filter=FALSE, debugger.show.values.use.inlays=TRUE, performance.watcher.unresponsive.interval.ms=1000, vcs.enable.add.ignored.directories.to.exclude=FALSE, ide.allow.merge.buttons=TRUE, use.winp.for.graceful.process.termination=FALSE, ide.tooltip.initialDelay=0, ide.require.transaction.for.model.changes=FALSE, ide.debug.in.title=TRUE, rdclient.asyncActions=false
Non-Bundled Plugins: com.intellij.resharper.HeapAllocationsViewer (2021.2.0), com.jetbrains.rider.android (212.5284.64), io.acari.DDLCTheme (21.0.0)

Screenshots

Screenshot (254)
Screenshot (255)

@Unthrottled
Copy link
Member

Ahh man, that's what it looks like for other people.......dang it.

It's supposed to look like this 😭

image

Does https://doki-theme.unthrottled.io/ not resolve for you, or take a really long time to load?

@justalemon
Copy link
Author

The page works as expected.

TBH the only thing I did was install Rider (cuz doki-theme/doki-theme-visualstudio#31, ha!), install The Doki Theme and press the Restart button for the extension to install and apply. Then I just changed the theme to Cinnamon and that was it.

@justalemon
Copy link
Author

By the way, how can I open the tab manually?

@Unthrottled
Copy link
Member

Unthrottled commented Dec 9, 2021

By the way, how can I open the tab manually?

Help -> Find Action

Enter Show Update Notification

Edit: this also works

image

The page works as expected.

Okay, well I'd like to know why the fancy page is not working, but I also should fix the plain page. Could you search through the logs (or provide the logs for me, Help -> Show Log in Explorer), looking to see if there is any Timeout stuff in there.

@justalemon
Copy link
Author

I don't see an option called "Show Log in Explorer" in the Help menu. Maybe you are talking about "Collect Logs"?

@Unthrottled
Copy link
Member

Lol, wups. I normally do:

Help -> Find Action

Enter Show Log in Explorer

I thought there was that option in the dropdown.

image

Open Log in Editor will open the containing folder for you, as well.

If you don't want to provided the log (cause of privacy stuff) I'm looking for things related to timeouts.

@justalemon
Copy link
Author

I don't have that option:
image
image

@Unthrottled
Copy link
Member

How about trying:

Help -> Find Action...

Enter Show Log in Explorer ?

@Unthrottled
Copy link
Member

Unthrottled commented Dec 16, 2021

Okay, so I spent a bunch of time refactoring the website to be smaller and load quicker. I've done everything up to the point of server side rendering to get the best user experience. I am going to update the fallback page (the original one in this issue) but I'd like to know if my outside fix worked.

@justalemon and/or @Dragon-0609 could you do me a favor and:

  • Go to Help -> Find Action
  • Enter Show Update Notification (choose the doki theme one)

And tell me if you get a page that looks like this 👇

image

FYI: It might look a bit different based on the version you are running at the moment though. Just wanting to know if it isn't the fallback/timeout html (like the original image in the issue is)

Please and thank you!

@Dragon-0609
Copy link
Contributor

Dragon-0609 commented Dec 16, 2021

Works well. 1366x768 px
bandicam 2021-12-16 17-34-50-072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants