fix: prioritize KUBECONFIG env over inCluster

[MJjainam]

This is the behaviour even for kubectl CLI.

[dark0dave]

This should be handled in config.go not in the kube.go. This is a configuration. Happy to change it. @stepanstipl wdyt?

[stepanstipl]

Hmm.. 🤔 I think it would be best to mirror kubectl behaviour in this aspect, as that's what everyone is used to (and I think it's a bit more complex than just checking one env variable). But I would also like to keep it simple, and for sure don't want to reinvent the wheel. Also, there're multiple ways to create the client config in the client-go clientcmd package.

Can we find out what exactly the kubectl does (code ref. would be great)?

[MJjainam]

@stepanstipl I was unable to find the exact way how kubectl loads. Although what I could find was that

kube-no-trouble/pkg/collector/kube.go

Line 61 in 1985e72

clientConfig := clientcmd.NewDefaultClientConfig(*config, &configOverrides)

client-go function does have loading rules from KUBECONFIG env variable.

[github-actions]

This PR has not seen any activity in last 60 days and has been marked as stale

[dark0dave]

this should be handled in config.go