Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool does not respect KUBECONFIG env variable if running on a cluster #495

Closed
MJjainam opened this issue Jun 15, 2023 · 3 comments
Closed

Comments

@MJjainam
Copy link

Ideally, the priority to pick target K8s version must be

  1. --kubeconfig
  2. KUBECONFIG env
  3. InCluster

But in our case we are skipping KUBECONFIG env variable and directly heading to inCluster. This does not follow the standard practice in other popular tools like kubectl, kubepug etc.

Example code from controller-runtime repo -> https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/client/config/config.go#L76

@MJjainam
Copy link
Author

Fix for the above is in this PR -> #499

@github-actions
Copy link

This issue has not seen any activity in last 60 days, and has been marked as stale.

@dark0dave
Copy link
Collaborator

This was resolved in the go config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants