Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad keyboard covered by alert #300

Open
pnome opened this issue Jul 10, 2021 · 7 comments
Open

iPad keyboard covered by alert #300

pnome opened this issue Jul 10, 2021 · 7 comments
Assignees
Labels

Comments

@pnome
Copy link

pnome commented Jul 10, 2021

I'm reposting this as a new issue as it didn't seem to get seen. Hopefully someone has an idea about whether it's fixable. I have my fingers crossed.

Describe the bug
With an iPad in landscape, and a dialog with a text field, when tapping in the text field, the keyboard covers the buttons of the dialog.

To Reproduce
Steps to reproduce the behavior:

Run the SCLAlertView-ObjectiveC example project on an iPad in landscape
Tap the "Show Edit" option
Tap in the text field
You can see it happening here: https://www.loom.com/share/7bc2516ff71240faac702304714811f6
Expected behavior
I expect the dialog to move up out of the way of the keyboard

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Version [e.g. 22]
Additional context
Notably, the same bug does not happen using the Swift SCLAlertView example code.
Also, if you tap Show Edit, then change to another app, then return, and THEN tap in the text field, everything works fine. This is a very strange bug.

@dogo dogo self-assigned this Jul 12, 2021
@dogo dogo added the bug label Jul 12, 2021
@dogo
Copy link
Owner

dogo commented Aug 26, 2021

@pnome
Copy link
Author

pnome commented Aug 26, 2021

@dogo , thanks for taking a look.
It's definitely still there. I noticed that in your screen recording you were on 10.3 simulator. Can you try it on iOS 14.5? That's where I'm seeing the bug.

Here's another screen recording showing how it works fine in the swift version, but still doesn't work in the ObjC version: https://loom.com/share/919793f4ff3040bfae160d26fc7191d9

Thanks,
Joe

dogo added a commit that referenced this issue Sep 14, 2021
@dogo
Copy link
Owner

dogo commented Sep 14, 2021

@pnome Could you please validate the fix/improve-keyboard-handling branch ??

dogo added a commit that referenced this issue Sep 14, 2021
@pnome
Copy link
Author

pnome commented Sep 14, 2021

Hi @dogo,

Thanks for looking into this. I'm not entirely sure how to test a specific branch. Could you let me know how I can install that branch via CocoaPods?

Or, is there a way I can download that branch and run the examples (like I did in the video)?

My wife is about to have baby, so I might not be able to get around to it for a few days.
Best,
Joe

@dogo
Copy link
Owner

dogo commented Sep 14, 2021

Hi @pnome , in your podfile put this:
pod 'SCLAlertView-Objective-C', :git => 'https://github.com/dogo/SCLAlertView.git', :branch => 'fix/improve-keyboard-handling'

and btw congrats! babies always make us happy

@pnome
Copy link
Author

pnome commented Oct 1, 2021

Hi @dogo,
Sorry it took me a while to get around to this. I tested the example in the new branch and it's still buggy.

Please see this video: https://loom.com/share/5e6bdddaedbe46c684df5e0754e6f515

Thanks,
Joe

dogo added a commit that referenced this issue Apr 6, 2022
@pnome
Copy link
Author

pnome commented Jan 16, 2023

Sorry it took me so long to get back to you. I didn't get an alert about your commit (maybe because there was no comment in the thread?) and I only just noticed that you'd made an edit.
I'm afraid I tested the demo project and it still seems very broken - https://www.loom.com/share/034728fffe3b431ab2c38c3d4e42e258

Hoping there's a way to fix it.
Thanks again,
Joe

dogo added a commit that referenced this issue Jun 10, 2023
dogo added a commit that referenced this issue Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants