Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure page_embed.* work sensibly without the enhancer #31

Open
Tracked by #35
reefdog opened this issue Nov 5, 2015 · 1 comment
Open
Tracked by #35

Ensure page_embed.* work sensibly without the enhancer #31

reefdog opened this issue Nov 5, 2015 · 1 comment

Comments

@reefdog
Copy link
Contributor

reefdog commented Nov 5, 2015

The enhancer is our personal entry into the embeds, but people should be able to load and use the page embed libraries directly without using the enhancer (or by using their own enhancer). Make sure there are no assumptions within page_embed.* that require the enhancer.

@reefdog
Copy link
Contributor Author

reefdog commented Nov 12, 2015

Our direct-load example on the sample page works:

<div id="foo"></div>
<script src="https://assets.documentcloud.org/embed/page/page_embed.js"></script>
<script>
  DocumentCloud.embed.load("https://www.documentcloud.org/documents/282753-lefler-thesis.html#document/p57", {
    container: '#foo'
  });
</script>

To get styles, you'll also need the CSS: <link rel="stylesheet" href="https://assets.documentcloud.org/embed/page/page_embed.css">

Not marking this as complete because I want to really test the bounds of this ability, but atm it does work if implementors want to play with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant