Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchdog isn't aware of Geyser usage - Bedrock client on Java server #58

Open
mithrandir opened this issue Feb 25, 2023 · 9 comments · May be fixed by #59
Open

Watchdog isn't aware of Geyser usage - Bedrock client on Java server #58

mithrandir opened this issue Feb 25, 2023 · 9 comments · May be fixed by #59

Comments

@mithrandir
Copy link

I'm running Spigotmc / Geysermc and the watch dog scripts cannot detect bedrock client connection. Thus my server is shutting down after 10 minutes even I'm playing and connecting. The easy way to mitigate the issue is assuming that Java server can host both of bedrock clients (UDP ports) and Java clients. Could we have such change?

PS. thanks for awesome documentation and the script. I'm AWS newbie and it only took 2 hours to setup the ECS cluster and lambda stuffs. Everything is working great except the bedrock client detection.

@yurisasc
Copy link

yurisasc commented Mar 3, 2023

This is an interesting issue. I'll have a look to see if I can help with this.

@yurisasc
Copy link

yurisasc commented Mar 3, 2023

@mithrandir I've opened a PR and published a test watchdog image. You can use the test image while waiting for the PR to be reviewed. You can do so by changing code:

image: isDockerInstalled()
? ecs.ContainerImage.fromAsset(
path.resolve(__dirname, '../../minecraft-ecsfargate-watchdog/')
)
: ecs.ContainerImage.fromRegistry(
'doctorray/minecraft-ecsfargate-watchdog'
),

into:

image: ecs.ContainerImage.fromRegistry( 
       'yurisasc/minecraft-ecsfargate-watchdog' 
     ), 

The new image should allow the watchdog to listen to the 19132 UDP port if you add GEYSER: true under this line:

SHUTDOWNMIN: config.shutdownMinutes,

@Rithmatist
Copy link

I'm running Spigotmc / Geysermc and the watch dog scripts cannot detect bedrock client connection. Thus my server is shutting down after 10 minutes even I'm playing and connecting. The easy way to mitigate the issue is assuming that Java server can host both of bedrock clients (UDP ports) and Java clients. Could we have such change?

PS. thanks for awesome documentation and the script. I'm AWS newbie and it only took 2 hours to setup the ECS cluster and lambda stuffs. Everything is working great except the bedrock client detection.

Would be easier to deploy with code :)

@mithrandir
Copy link
Author

@yurisasc Thanks for quick change! It worked fine now, confirmed my Bedrock connection is recognized.

@doctorray117
Copy link
Owner

Hello. Looks good, thanks for the additional testing. @yurisasc Did you have a chance to try a fresh deployment with CDK to ensure that method worked as well?

@yurisasc
Copy link

yurisasc commented Mar 9, 2023

@doctorray117 Yup. I've set up a new staging server using the image, which also works.
The watchdog still works as expected. Such as stopping after $SHUTDOWNMIN minutes of the last activity, stopping after $STARTUPMIN minutes if there's no activity after the server starts, recognising java and bedrock connections, and sending startup and shutdown notifications.

Happy for you to review the code (or even the commit messages) if it doesn't match your format :)

@doctorray117
Copy link
Owner

@yurisasc No, it's good. Apologies for the delay. I'm happy with the formatting and my testing time has been limited. I'll get it merged and deploy it out to the public docker repo over the weekend, and come back and close this issue afterward.

@Rithmatist
Copy link

@yurisasc No, it's good. Apologies for the delay. I'm happy with the formatting and my testing time has been limited. I'll get it merged and deploy it out to the public docker repo over the weekend, and come back and close this issue afterward.

Do you have discord? I found a method to support modpacks and some other features

@GarrettBeatty
Copy link

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants