Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCK-2471: Reenable skipped test #1863

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented Oct 31, 2023

Description
This PR unskips a UI2 integration test that was skipped as part of a previous PR. Per the description in https://ucsc-cgl.atlassian.net/browse/DOCK-2471, a flaky test was disabled. Most of the description refers to a test in mytools.ts, however, the skipped test is in myworkflows.ts. Possibly, this test was inadvertently disabled because the string argument to it() is the same as the test that was failing in mytools?

it('visit another page then come back', () => {

The mytools test was fixed in another previous PR.

Review Instructions
Confirm that the reenabled test is passing when CircleCI runs.

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2471
dockstore/dockstore#5696

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f81733) 40.47% compared to head (3fd09ee) 40.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1863   +/-   ##
========================================
  Coverage    40.47%   40.47%           
========================================
  Files          366      366           
  Lines        11359    11359           
  Branches      2913     2913           
========================================
  Hits          4598     4598           
  Misses        4448     4448           
  Partials      2313     2313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl svonworl self-assigned this Oct 31, 2023
@svonworl svonworl merged commit b8a4e19 into develop Oct 31, 2023
20 checks passed
@svonworl svonworl deleted the feature/dock-2471/unskip-test branch October 31, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants