Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoke tests for both Twitter and Mastodon #1861

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Oct 26, 2023

Description
Currently, Twitter widget is in staging/prod, Mastodon is in qa. Add an "or" selector to handle both cases.

Created a follow-up ticket, SEAB-5992, to undo after 1.15 is released.

Review Instructions
Nightly smoke tests should pass in all environments.

Issue
No issue created.

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

Currently, Twitter is in staging/prod, Mastodon is in qa
@coverbeck coverbeck self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a8173a) 40.53% compared to head (90025fa) 40.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1861      +/-   ##
===========================================
- Coverage    40.53%   40.52%   -0.02%     
===========================================
  Files          365      365              
  Lines        11283    11283              
  Branches      2896     2896              
===========================================
- Hits          4574     4572       -2     
- Misses        4407     4409       +2     
  Partials      2302     2302              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coverbeck coverbeck merged commit 99034c9 into develop Oct 26, 2023
10 checks passed
@coverbeck coverbeck deleted the feature/smokeTwitterAndMastodon branch October 26, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants