Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-5982: fix news box on homepage #1856

Merged
merged 1 commit into from
Oct 24, 2023
Merged

SEAB-5982: fix news box on homepage #1856

merged 1 commit into from
Oct 24, 2023

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Oct 23, 2023

Description
Fixes the news box on the homepage by putting the tag back into its parent div.

It looks like it got messed up in #1837

Review Instructions
Review that the homepage news and updates box looks normal.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5982

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@hyunnaye hyunnaye self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0cbefeb) 40.49% compared to head (a3cd0f1) 40.49%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1856   +/-   ##
========================================
  Coverage    40.49%   40.49%           
========================================
  Files          364      364           
  Lines        11268    11268           
  Branches      2891     2891           
========================================
  Hits          4563     4563           
  Misses        4405     4405           
  Partials      2300     2300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyunnaye hyunnaye merged commit 54f50f6 into develop Oct 24, 2023
9 of 10 checks passed
@hyunnaye hyunnaye deleted the feature/SEAB-5982 branch October 24, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants