Feature/5568/metrics

[coverbeck]

Description
UI portion of metrics, web service PR is dockstore/dockstore#5693.

Web service PR has rationalization for metrics surfaced, but wording of text could probably use improvement.

Updated versions table; because space is tight on the versions table, I got rid of verified platforms if metrics is enabled. Sort of arbitrary, but I feel like we're hoping to get more metrics data going forward than verified platforms.

Review Instructions
Follow review instructions from dockstore/dockstore#5693

Issue
dockstore/dockstore#5568

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

• Check that your code compiles by running npm run build
• Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
• If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
• Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
• If displaying markdown, use the markdown-wrapper component, which does extra sanitization
• Do not use cookies, although this may change in the future
• Run npm audit and ensure you are not introducing new vulnerabilities
• Do due diligence on new 3rd party libraries, checking for CVEs
• Don't allow user-uploaded images to be served from the Dockstore domain
• If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
• Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (31921a3) 40.41% compared to head (533218d) 40.49%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1848      +/-   ##
===========================================
+ Coverage    40.41%   40.49%   +0.08%     
===========================================
  Files          364      364              
  Lines        11261    11268       +7     
  Branches      2888     2891       +3     
===========================================
+ Hits          4551     4563      +12     
+ Misses        4411     4405       -6     
- Partials      2299     2300       +1     

Files	Coverage Δ
...ion/github-apps-logs/github-apps-logs.component.ts	10.41% <ø> (+0.21%)	⬆️
src/app/search/search.component.ts	34.13% <ø> (+1.06%)	⬆️
src/app/shared/constants.ts	100.00% <100.00%> (ø)
src/app/shared/pipe/pipe.module.ts	50.00% <ø> (ø)
src/app/workflow/workflow.component.ts	2.52% <ø> (ø)
src/app/search/map-friendly-values.pipe.ts	72.22% <75.00%> (-1.12%)	⬇️
src/app/workflow/versions/versions.component.ts	64.00% <72.72%> (+5.86%)	⬆️
src/app/search/state/search.service.ts	21.20% <14.28%> (-0.18%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coverbeck]

Noticed this when adding PlatformPartnerPipe to map-friendly-values because it caused a compilation error. In Angular, pipes should be injected, not instantiated directly (except for tests).

[coverbeck]

But not sure how to deal with the one above it, so left it. :)

[coverbeck]

Sheesh, a multitude of test failures, removing reviewers until I figure that out.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

63.2% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint