review feedback

dockstore · Nov 26, 2024 · e816f6b · e816f6b
1 parent 6fad0ee
commit e816f6b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cypress/e2e/group1/checkerWorkflowFromWorkflow.ts b/cypress/e2e/group1/checkerWorkflowFromWorkflow.ts
@@ -124,7 +124,7 @@ describe('Checker workflow test from my-workflows', () => {
 
       goToTab('Versions');
       cy.get('[data-cy=date-modified-header]').should('be.visible').click();
-      cy.wait(1000);
+      cy.wait(1000); //waits for the sorting to finish to ensure Actions button is clicked for the right version (was encountering flakiness)
 
       cy.contains('button', 'Actions').click();
       cy.get('[data-cy=set-default-version-button]').should('be.visible').click();

diff --git a/src/app/workflow/versions/versions-datasource.ts b/src/app/workflow/versions/versions-datasource.ts
@@ -31,7 +31,8 @@ export class VersionsDataSource implements DataSource<WorkflowVersion> {
 
   /**
    * Updates the datasource from the endpoint
-   * @param {string} filter  A string to filter path by ("cgpmap")
+   * @param {boolean} publicPage Boolean for if we are loading versions for the public page
+   * @param {workflowId} workflowId Id of  parent workflow
    * @param {string} sortDirection  "asc" or "desc"
    * @param {number} pageIndex  The entry number to start listing from (page size * page number)
    * @param {number} pageSize  The page size (number of tools to return)