Allow Unix socket transport on Windows platform #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation is the same as for Unix like systems, but is using MAX_PATH value of Windows platform for sanity check. Signed-off-by: Arthur Sengileyev <[email protected]>
|
Duplicate of #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
Implementation is the same as for Unix like systems, but is using MAX_PATH value of Windows platform for sanity check.
- What I did
Copied implementation from
_unixversion and adapted to use Windows specific constants for sanity checks- How I did it
MAX_PATH value was taken from https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
- How to verify it
- Description for the changelog
Allow Unix socket transport on Windows platform
- A picture of a cute animal (not mandatory but encouraged)