Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ini memory_limit and output_buffering #256

Open
Jonniedev opened this issue Feb 4, 2024 · 3 comments
Open

Missing ini memory_limit and output_buffering #256

Jonniedev opened this issue Feb 4, 2024 · 3 comments

Comments

@Jonniedev
Copy link

as described at: drupal memory requirements we need at least 128 MB.
also as of 10.2.0, It is now recommended to enable output buffering in php.ini

RUN echo 'memory_limit = 128M' > $PHP_INI_DIR/conf.d/docker-php-memlimit.ini \
    && echo 'output_buffering = On' > $PHP_INI_DIR/conf.d/docker-php-outbuf.ini
@mstenta
Copy link

mstenta commented Feb 4, 2024

+1

The output buffer warning in Drupal status report has been coming up a lot for users of farmOS (a Drupal distribution that offers a Docker image based on this image).

For production environments, the PHP base image recommends enabling default PHP production configuration in downstream images, which also enabled output buffering:

# Use the default production configuration
RUN mv "$PHP_INI_DIR/php.ini-production" "$PHP_INI_DIR/php.ini"

I don't think we can do that in this image, and it should be left up to downstream image maintainers/projects to implement.

But it may be worth considering enabling output buffering in this image as a baseline, since without it Drupal's status report shows a warning.

@tianon
Copy link
Member

tianon commented Feb 5, 2024

Yeah, enabling output buffering is 100% solid -- an explicit upstream recommendation is the best thing to convince me 😄

The memory limit is a little hazier -- they clearly recommend something, but the specific value they recommend is not as explicitly spelled out. 😞

@mstenta
Copy link

mstenta commented Feb 5, 2024

Agreed.

Also I think PHP's default memory_limit is 128M so assuming this image uses that, then it's already "done". :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants