-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the default php.ini (prod or dev) #246
Comments
Perhaps this image should just include the same instructions, without making the decision to use one or the other. We use this image as the basis for both our production and development environments. If the upstream |
This mean we always need to create a child image and add somethings like
I cannot think of a good way to manage this. |
The opcache revalidate frequency is not compatible with dev needs. from drupal image dockerfile
Enough! I will use the official php image instead and simply add the extension needed. |
I hear your argument about being production ready and secure by default, and I agree that would be nice, but unfortunately it is not that simple. Changing this now would constitute a breaking change, which could affect downstream users of this image. The issue you referenced in the upstream PHP image made the same point (docker-library/php#692):
The reason that it was originally built this way was because that is how PHP itself ships by default. It is up to the downstream user to decide how they want to configure it:
The solution, as you described, is to create a child image...
You can still use the
|
Just add it to your sites Dockerfile where you define everything else thats not included in the base-image, modules, themes, timezones, server-settings etc...
|
Depending how you orchestrate your containers, an init container could do the trick. No need for a seperate image. |
Default php.ini is not set?
From https://hub.docker.com/_/php
The doc may also explain how php.ini be optionally exposed in the host using https://docs.docker.com/compose/compose-file/08-configs/
The text was updated successfully, but these errors were encountered: