You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IMO, vals is the buffer to store pull results. So it does not have to be equal to total_val. Greater size should also be allowed. So I propose changing to CHECK_GE(vals->size(), total_val);.
The text was updated successfully, but these errors were encountered:
https://github.com/dmlc/ps-lite/blob/master/include/ps/kv_app.h#L689
IMO,
vals
is the buffer to store pull results. So it does not have to be equal tototal_val
. Greater size should also be allowed. So I propose changing toCHECK_GE(vals->size(), total_val);
.The text was updated successfully, but these errors were encountered: