Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set more sensible default threads count #196

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Set more sensible default threads count #196

merged 4 commits into from
Nov 17, 2023

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Oct 25, 2023

fix #88

@Moelf
Copy link
Contributor Author

Moelf commented Nov 4, 2023

Bump

@ExpandingMan
Copy link
Collaborator

Did you see my above comment?

@Moelf
Copy link
Contributor Author

Moelf commented Nov 5, 2023

@ExpandingMan I think you didn't commit the review comment:
image

@ExpandingMan
Copy link
Collaborator

Gah, sorry about that, I hate github's entire review functionality, so annoying.

@Moelf Moelf force-pushed the set_default_threads branch from dc29c70 to 05e8733 Compare November 5, 2023 22:36
@Moelf Moelf force-pushed the set_default_threads branch from 05e8733 to c54cfcc Compare November 5, 2023 22:38
@Moelf
Copy link
Contributor Author

Moelf commented Nov 5, 2023

ok let's try this

@ExpandingMan ExpandingMan merged commit 0b4977a into dmlc:master Nov 17, 2023
4 of 5 checks passed
@ExpandingMan
Copy link
Collaborator

Thanks!

@Moelf Moelf deleted the set_default_threads branch November 18, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExpandingMan ExpandingMan ExpandingMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of threads used may be more than number of processes
2 participants
@Moelf @ExpandingMan