Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: evicting old entries in top_domains/requesters metrics #537

Open
dmachard opened this issue Jan 1, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@dmachard
Copy link
Owner

dmachard commented Jan 1, 2024

The following top metrics need to be updated to remove old top entries

  • dnscollector_top_domains
  • dnscollector_top_requesters
  • ...
@dmachard dmachard added the enhancement New feature or request label Jan 1, 2024
@dmachard dmachard changed the title prometheus: evicting old entries in top metrics prometheus: evicting old entries in top_domains/requesters metrics Jan 1, 2024
@v0rdych
Copy link

v0rdych commented Oct 1, 2024

Hi, maybe it's worth to add new setting (measured in seconds) in configuration?
Which will be used in separate thread clearing all TopMap structures based on that setting?

I've tried just clear all TopMap entries when metrics are collected by external system and it also seems working solution at least when one system is collecting metrics. And this also works with that fact, that all "gaugeTop**" metrics seem to be not GAUGE, but COUNTER in nature.
So clearing TopMap structures in the moment of collecting entries and changing grafana dashboard's formulas to rate instead of increase gave me correct messages-per-second values of top-domain entries.
But still have no solution when metric collection is performed from multiple systems, so *TopMap structures are cleared too early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants