Deprecate Package.getInternalSubPackage, simplify DepedencyResolver #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PackageManager will always eagerly load subpackages, whether they are path based or embedded (see addPackages). So calling getInternalSubPackage if getSubPackage returned null will never yield a non-Nullable object. In short, we can simplify that code greatly, and as Package.getInternalSubPackage does not handle all use case and require using the PackageManager anyway, just deprecate it and direct people to the right function.
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5286232 bin/dub
+executable size=5282136 bin/dub
rough build time=61sFull build output |
|
@thewilsonator : This one too ? ;) |
thewilsonator
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PackageManager will always eagerly load subpackages, whether they are path based or embedded (see addPackages). So calling getInternalSubPackage if getSubPackage returned null will never yield a non-Nullable object.
In short, we can simplify that code greatly, and as Package.getInternalSubPackage does not handle all use case and require using the PackageManager anyway, just deprecate it and direct people to the right function.