Skip to content

Commit

Permalink
[REMOVE] Revert the fix to test CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Geod24 committed Feb 9, 2024
1 parent c245b80 commit de8f71d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion source/dub/generators/build.d
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ class BuildGenerator : ProjectGenerator {
auto cwd = settings.toolWorkingDirectory;
bool generate_binary = !(buildsettings.options & BuildOption.syntaxOnly);

auto build_id = buildsettings.computeBuildID(pack.path, config, settings);
auto build_id = buildsettings.computeBuildID(config, settings);

// make all paths relative to shrink the command line
string makeRelative(string path) { return shrinkPath(NativePath(path), cwd); }
Expand Down
5 changes: 1 addition & 4 deletions source/dub/generators/generator.d
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,7 @@ package(dub) NativePath targetCacheDir(NativePath cachePath, in Package pkg, str
* library-debug-Z7qINYX4IxM8muBSlyNGrw
* ```
*/
package(dub) string computeBuildID(in BuildSettings buildsettings,
in NativePath packagePath, string config, GeneratorSettings settings)
package(dub) string computeBuildID(in BuildSettings buildsettings, string config, GeneratorSettings settings)
{
import std.conv : to;

Expand All @@ -844,8 +843,6 @@ package(dub) string computeBuildID(in BuildSettings buildsettings,
settings.platform.architecture,
[
(cast(uint)(buildsettings.options & ~BuildOption.color)).to!string, // exclude color option from id
// Needed for things such as `__FULL_FILE_PATH__`
packagePath.toNativeString(),
settings.platform.compilerBinary,
settings.platform.compiler,
settings.platform.compilerVersion,
Expand Down
2 changes: 1 addition & 1 deletion source/dub/generators/targetdescription.d
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class TargetDescriptionGenerator : ProjectGenerator {
d.packages = ti.packages.map!(p => p.name).array;
d.rootConfiguration = ti.config;
d.buildSettings = ti.buildSettings.dup;
const buildId = computeBuildID(d.buildSettings, ti.pack.path, ti.config, settings);
const buildId = computeBuildID(d.buildSettings, ti.config, settings);
const filename = settings.compiler.getTargetFileName(d.buildSettings, settings.platform);
d.cacheArtifactPath = (targetCacheDir(settings.cache, ti.pack, buildId) ~ filename).toNativeString();
d.dependencies = ti.dependencies.dup;
Expand Down

0 comments on commit de8f71d

Please sign in to comment.