-
-
Notifications
You must be signed in to change notification settings - Fork 369
/
dstyle.dd
510 lines (433 loc) · 16.9 KB
/
dstyle.dd
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
Ddoc
$(D_S The D Style,
<img src="images/style3.gif" border=0 align=right alt="D Style" height=200>
$(P
$(I The D Style) is a set of style conventions for writing
D programs. The D Style is not enforced by the compiler. It is
purely cosmetic and a matter of choice. Adhering to the D Style,
however, will make it easier for others to work with your
code and easier for you to work with others' code.
The D Style can form the starting point for a project
style guide customized for your project team.
)
$(P
Submissions to Phobos and other official D source code will
follow these guidelines.
)
$(H3 $(LNAME2 whitespace, Whitespace))
$(UL
$(LI One statement per line.)
$(LI Use spaces instead of hardware tabs.)
$(LI Each indentation level will be four columns.)
)
$(H3 $(LNAME2 naming_conventions, Naming Conventions))
$(DL
$(DT $(LNAME2 naming_general, General))
$(DD Unless listed otherwise below, names should be camelCased (this
includes $(I all) variables). So, names formed by joining multiple
words have each word other than the first word capitalized. Also, names
do not begin with an underscore $(SINGLEQUOTE _) unless they are
private.
-------------------------------
int myFunc();
string myLocalVar;
-------------------------------
)
$(DT $(LNAME2 naming_modules, Modules))
$(DD Module and package names should be all lowercase, and only contain
the characters [a..z][0..9][_]. This avoids problems when dealing with
case-insensitive file systems.
-------------------------------
import std.algorithm;
-------------------------------
)
$(DT $(LNAME2 naming_classes, Classes, Interfaces, Structs, Unions, Enums, Non-Eponymous Templates))
$(DD The names of user-defined types should be PascalCased, which is the
same as camelCased except that the first letter is uppercase.
-------------------------------
class Foo;
struct FooAndBar;
-------------------------------
)
$(DT $(LNAME2 naming_eponymous_templates, Eponymous Templates))
$(DD Templates which have the same name as a symbol within that template
(and instantiations of that template are therefore replaced with that
symbol) should be capitalized in the same way that the inner symbol
would be capitalized if it weren't in a template - e.g. types should
be PascalCased and values should be camelCased.
-------------------------
template GetSomeType(T) { alias GetSomeType = T; }
template isSomeType(T) { enum isSomeType = is(T == SomeType); }
template MyType(T) { struct MyType { ... } }
template map(fun...) { auto map(Range r) { ... } }
-------------------------
)
$(DT $(LNAME2 naming_functions, Functions))
$(DD Function names should be camelCased, so their first letter is lowercase.
This includes properties and member functions.
-------------------------------
int done();
int doneProcessing();
-------------------------------
)
$(DT $(LNAME2 naming_constants, Constants))
$(DD The names of constants should be camelCased just like normal variables.
-------------------------------
enum secondsPerMinute = 60;
immutable hexDigits = "0123456789ABCDEF";
-------------------------------
)
$(DT $(LNAME2 naming_enum_members, Enum members))
$(DD The members of enums should be camelCased, so their first letter is
lowercase.
-------------------------------
enum Direction { bwd, fwd, both }
enum OpenRight { no, yes }
-------------------------------
)
$(DT $(LNAME2 naming_keywords, Keywords))
$(DD If a name would conflict with a keyword, and it is desirable to use the
keyword rather than pick a different name, a single underscore
$(SINGLEQUOTE _) should be appended to it. Names should not be
capitalized differently in order to avoid conflicting with keywords.
-------------------------------
enum Attribute { nothrow_, pure_, safe }
-------------------------------
)
$(DT $(LNAME2 naming_acronyms, Acronyms))
$(DD When acronyms are used in symbol names, all letters in the acronym
should have the same case. So, if the first letter in the acronym
is lowercase, then all of the letters in the acronym are lowercase, and
if the first letter in the acronym is uppercase, then all of the
letters in the acronym are uppercase.
-------------------------------
class UTFException;
ubyte asciiChar;
-------------------------------
)
$(DT $(LNAME2 naming_udas, User-Defined Attributes))
$(DD For symbols that are only to be used as user-defined attributes the
names should be camelCased, so their first letter is lowercase. This
convention takes precedence over any previously mentioned conventions.
This matches conventions of the built in attributes like `@safe`,
`@nogc` and the special compiler recognized UDA `@selector`.
-------------------------------
struct Foo {} // this struct follows the regular naming conventions
// this struct is only intended to be used as an UDA and therefore overrides the
// regular naming conventions for structs
struct name { string value; }
@name("bar") Foo foo;
-------------------------------
)
)
$(H3 $(LNAME2 type_aliases, Type Aliases))
$(P The D programming languages offers two functionally equivalent syntaxes for type aliases, but ...)
-------------------------------
alias size_t = uint;
-------------------------------
$(P ... is preferred over ...)
-------------------------------
alias uint size_t;
-------------------------------
$(P ... because ...)
$(UL
$(LI It follows the already familiar assignment syntax instead of the inverted typedef syntax from C)
$(LI In verbose declarations, it is easier to see what is being declared)
)
-------------------------------
alias important = someTemplateDetail!(withParameters, andValues);
alias Callback = ReturnType function(Arg1, Arg2) pure nothrow;
-------------------------------
$(P vs.)
-------------------------------
alias someTemplateDetail!(withParameters, andValues) important;
alias ReturnType function(Arg1, Arg2) pure nothrow Callback;
-------------------------------
$(P Meaningless type aliases like ...)
-------------------------------
alias VOID = void;
alias INT = int;
alias pint = int*;
-------------------------------
$(P ... should be avoided.)
$(H3 $(LNAME2 declaration_style, Declaration Style))
$(P Since the declarations are left-associative, left justify them:)
-------------------------------
int[] x, y; // makes it clear that x and y are the same type
int** p, q; // makes it clear that p and q are the same type
-------------------------------
$(P to emphasize their relationship. Do not use the C style:)
-------------------------------
int []x, y; // confusing since y is also an int[]
int **p, q; // confusing since q is also an int**
-------------------------------
$(H3 $(LNAME2 operator_overloading, Operator Overloading))
$(P Operator overloading is a powerful tool to extend the basic
types supported by the language. But being powerful, it has
great potential for creating obfuscated code. In particular,
the existing D operators have conventional meanings, such
as $(SINGLEQUOTE +) means $(SINGLEQUOTE add) and $(SINGLEQUOTE <<)
means $(SINGLEQUOTE shift left).
Overloading operator $(SINGLEQUOTE +) with a meaning different from $(SINGLEQUOTE add)
is arbitrarily confusing and should be avoided.
)
$(H3 $(LNAME2 hungarian_notation, Hungarian Notation))
$(P Using Hungarian notation to denote the type of a variable
is a bad idea.
However, using notation to denote the purpose of a variable
(that cannot be expressed by its type) is often a good
practice.)
$(H3 $(LNAME2 properties, Properties))
$(P Functions should be property functions whenever appropriate. In
particular, getters and setters should generally be avoided in favor of
property functions. And in general, whereas functions should be verbs,
properties should be nouns, just like if they were member variables.
Getter properties should $(I not) alter state.)
$(H3 $(LNAME2 property-syntax, Property syntax))
$(P Do not use $(LINK2 spec/function.html#pseudo-member, UFCS) or
$(LINK2 spec/function.html#optional-parenthesis, Optional Parentheses) outside of their intended use cases.
Omitting parentheses is useful in generic code that does not care whether a member is a field or
a function, for example the range primitive `front`.
It can also make a chain of range functions more compact.
However, when a simple call is made to a function with side effects, prefer 'regular' function call syntax.
)
-------------------------------
import std.range, std.stdio;
void main()
{
// good
writeln();
writeln("hello");
iota(0, 10).dropOne.array.front.writeln;
// bad
writeln;
"hello".writeln;
writeln = "hello";
}
-------------------------------
$(H3 $(LNAME2 documentation, Documentation))
$(P
All public declarations will be documented in
$(LINK2 spec/ddoc.html, Ddoc) format and should have at least `Params` and
`Returns` sections.
)
$(H3 $(LNAME2 unittest, Unit Tests))
$(P
As much as practical, all functions will be exercised
by unit tests using unittest blocks immediately following
the function to be tested.
Every path of code should be executed at least once,
verified by the $(LINK2 code_coverage.html, code coverage analyzer).
)
$(H2 $(LNAME2 phobos, Additional Requirements for Phobos))
$(P
In general, this guide does not try to recommend or require that code
conform to any particular formatting guidelines. The small section on
whitespace at the top contains its only formatting guidelines. However, for
Phobos and other official D source code, there are additional requirements:
)
$(H4 $(LNAME2 phobos_brackets, Brackets))
$(P Braces should be on their own line. There are a few exceptions to this
(such as when declaring lambda functions), but with any normal function
block or type definition, the braces should be on their own line.)
-------------------------------
void func(int param)
{
if (param < 0)
{
...
}
else
{
...
}
}
-------------------------------
$(P Avoid unnecessary parentheses:)
-------------------------------
(a == b) ? "foo" : "bar"; // NO
a == b ? "foo" : "bar"; // OK
-------------------------------
$(H4 $(LNAME2 phobos_line_length, Line length))
$(P Lines have a soft limit of 80 characters and a hard limit of 120
characters. This means that most lines of code should be no longer than
80 characters long but that they $(I can) exceed 80 characters when
appropriate. However, they can $(I never) exceed 120 characters.)
$(LISTSECTION phobos_whitespace, Whitespace,
$(LI Put a space after `for`, `foreach`, `if`, `while`, and `version`: )
-------------------------------
for (…) { … }
foreach (…) { … }
static foreach (…) { … }
if (x) { … }
static if (x) { … }
while (…) { … }
do { … } while (…);
version (…) { … }
-------------------------------
$(LI Chains containing `else if (…)`, `else static if (…)` or `else version (…)`
should set the keywords on the same line:)
-------------------------------
if (…)
{
…
}
else if (…)
{
…
}
-------------------------------
$(LI Put a space between binary operators, assignments, `cast`, and lambdas:)
-------------------------------
a + b
a / b
a == b
a && b
arr[1 .. 2]
int a = 100;
b += 1;
short c = cast(short) a;
filter!(a => a == 42);
-------------------------------
$(LI Put no space between unary operators, after `assert`, function calls:)
-------------------------------
a = !a && !(2 == -1);
bool b = ~a;
auto d = &c;
e++;
assert(*d == 42);
callMyFancyFunction("hello world");
-------------------------------
)
$(LISTSECTION phobos_imports, Imports,
$(LI Local, selective imports should be preferred over global imports)
$(LI Selective imports should have a space before and after the colon (`:`) like
`import std.range : zip`)
$(LI Imports should be sorted lexicographically.)
)
$(LISTSECTION phobos_return_types, Return type,
$(LI The return type should be stated $(I explicitly) wherever possible,
as it makes the documentation and source code easier to read.)
$(LI $(LINK2 https://dlang.org/spec/struct.html#nested, Function-nested) structs
(aka $(LINK2 https://wiki.dlang.org/Voldemort_types, Voldemort types))
should be preferred over public `struct`s.)
)
$(LISTSECTION phobos_attributes, Attributes,
$(LI $(I Non-templated) functions should be annotated with
matching attributes (`@nogc`, `@safe`, `pure`, `nothrow`).)
$(LI If the template arguments for a $(I templated) function affect whether
an attribute is appropriate, then the function should $(B not) be
annotated with that attribute so that the compiler can infer it.
However, if the attribute is not affected by the template arguments
(and thus would always be inferred), then the function should be
explicitly annotated with that attribute just like a non-templated
function would be.)
$(LI Attributes should be listed in alphabetical ordering, e.g. `const @nogc nothrow pure @safe`
(the ordering should ignore the leading `@`).
)
$(LI $(B Every) $(I unittest) should be annotated
(e.g. `pure nothrow @nogc @safe unittest { ... }`)
to ensure the existence of attributes on the templated function.)
)
$(LISTSECTION phobos_templates, Templates,
$(LI `unittest` blocks should be avoided in templates. They will generate
a new `unittest` for each instance, hence tests should be put
outside of the template.)
)
$(LISTSECTION phobos_declarations, Declarations,
$(LI Constraints on declarations should have the same indentation level as
their declaration:)
-------------------------------
void foo(R)(R r)
if (R == 1)
-------------------------------
$(LI Pre and post contracts should have the same indentation level as their
declaration. The expression-based syntax should be preferred when the
equivalent long-form syntax would have a single `assert` statement.
Put a space after `in`/`out` similar to `if` constraints:)
-------------------------------
// Prefer:
T transmogrify(T)(T value)
if (isIntegral!T)
in (value % 7 == 0)
out (result; result % 11 == 0)
{
// ...
}
// over this:
T transmogrify(T)(T value)
if (isIntegral!T)
in { assert(value % 7 == 0); }
out (result) { assert(result % 11 == 0); }
do
{
// ...
}
-------------------------------
$(LI Invariants should use the expression-based syntax when the equivalent
long-form syntax would have a single `assert` statement. Put a space
between `invariant` and the opening parentheses:)
-------------------------------
struct S
{
int x;
invariant (x > 0);
}
-------------------------------
)
$(LISTSECTION phobos_class_struct_field_declaration, Class/Struct Field Declarations,
$(LI In structs and classes, there should only be one space between the type of
the field and its name. This avoids problems with future changes generating a
larger git diff than necessary.)
-------------------------------
class MyClass
{
// bad
int a;
double b;
// good
int x;
double y;
}
-------------------------------
)
$(LISTSECTION phobos_documentation, Documentation,
$(LI Every public symbol should be exposed in the documentation:)
---
/// A public symbol
enum myFancyConstant;
---
$(LI Every public function should have a Ddoc description and documented
`Params:` and `Returns:` sections (if applicable):)
---
/**
Checks whether a number is positive.
`0` isn't considered as positive number.
Params:
number = number to be checked
Returns: `true` if the number is positive, `0` otherwise.
See_Also: $(LREF isNegative)
*/
bool isPositive(int number)
{
return number > 0;
}
---
$(LI Text in sections (e.g. `Params:`, `Returns:`, `See_Also`) should be indented by one level if it spans more than the line of the section.)
$(LI Documentation comments should not use more than two stars `/**` or two pluses `/++` in the header line.)
$(LI Either Block comments (`/**`) or nesting block comments (`/++`) should be used except when the ddoc comment is a ditto comment such as `/// Ditto`)
$(LI Documentation comments should not have leading stars on each line.)
$(LI Text example blocks should use three dashes (`---`) only.)
)
$(BR)
$(P
We are not necessarily recommending that all code follow these rules.
They're likely to be controversial in any discussion on coding standards.
However, they are required in submissions to Phobos and other official D
source code.
)
)
Macros:
TITLE=The D Style
LISTSECTION=$(H4 $(LNAME2 $1, $2)) $(UL $(SKIPFIRST $+))
SKIPFIRST=$+