Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Super-Module for LibSvm/Liblinear #434

Closed
Horsmann opened this issue Feb 2, 2018 · 5 comments
Closed

Create Super-Module for LibSvm/Liblinear #434

Horsmann opened this issue Feb 2, 2018 · 5 comments
Assignees
Milestone

Comments

@Horsmann
Copy link
Member

Horsmann commented Feb 2, 2018

Both modules use the same data format and could use a shared super-module.
This would reduce code redundancy considerably. Except for the actual API calls to the backend-SVM, the TC Code is identical (in behavior not in actual line-of-codes).

@zesch any idea for a new module name for this middle-hierarchy module ?

@Horsmann Horsmann added this to the 1.0.0 milestone Feb 2, 2018
@Horsmann Horsmann self-assigned this Feb 2, 2018
@zesch
Copy link
Member

zesch commented Feb 2, 2018 via email

@reckart
Copy link
Member

reckart commented Feb 2, 2018

Isn't a shared module that is used by two other modules lower in the hierarchy?

@Horsmann
Copy link
Member Author

Horsmann commented Feb 2, 2018

Hm, depends how you look at it. If you think of the TC project as a (computer science) tree then the leafs are the lowest level, i.e. most specific, with this LibX project being an intermediate branch between the root and the leaf for the LibSvm and Liblinear project?

It might be possible to let SvmHmm use the same top-level project and #428 might benefit from it, too. Some name that express almost-standard-data-format-for-many-machin-learning-tools-project would be good :)

@Horsmann
Copy link
Member Author

Horsmann commented Feb 3, 2018

how about dkpro-tc-ml-svm-io, and -liblinear and -libsvm would get a dependency on this project?

@reckart
Copy link
Member

reckart commented Feb 3, 2018

I suppose in DKPro Core, it would be called dkpro-core-io-<formatname> - no idea what a suitable format name would be in this case though... is it again a "tab separated format" (tsv)... or better to name it after the first/most prominent tool that uses it...?

Horsmann added a commit that referenced this issue Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 3, 2018
@Horsmann Horsmann closed this as completed Feb 3, 2018
Horsmann added a commit that referenced this issue Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants