Add function calculate_correct_creature_max_health to fix issue with modifier #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before setting the health to the new creature, to get the modifier effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
calculate_correct_creature_max_healthfunction and updated the relevant game files accordingly.The reasons for this addition are:
To fix an oversight with the health modifier: Lair Recovery, Toking Recovery, and Torture Damage were incorrectly affected by the modifier.
To eliminate the need for the 3rd argument in
compute_creature_max_health.Additionally, I removed the soft cap on health, allowing creatures to have an exceptionally high amount of health, should the mapmaker choose to do so.
While working on this, I also reformatted the functions I encountered during the process. Hope you don't mind.